Move h5py import to specific function.#33
Merged
ericonr merged 1 commit intolnls-fac:masterfrom Mar 13, 2025
Merged
Conversation
Contributor
Author
gustavosr8
force-pushed
the
minimize-dependencies
branch
from
2646c75 to
9b82f74
Compare
anacso17
reviewed
Mar 10, 2025
ericonr
reviewed
Mar 10, 2025
When we use mathphys on siriuspy to use any other function then load or save hdf5 files, we shouldn't have to install h5py, since we are not using any of the resources from this lib.
gustavosr8
force-pushed
the
minimize-dependencies
branch
from
9b82f74 to
deba706
Compare
ericonr
approved these changes
Mar 10, 2025
anacso17
requested review from
Gabrielrezende-asc,
fernandohds564,
murilobalves,
vellosok75 and
xresende
and removed request for
fernandohds564
anacso17
approved these changes
Mar 10, 2025
vellosok75
approved these changes
Mar 10, 2025
xresende
approved these changes
Mar 12, 2025
Gabrielrezende-asc
approved these changes
Mar 12, 2025
Contributor
Author
|
I don't have a merge button, so if any of the codeowners could merge I'd be grateful! |
murilobalves
approved these changes
Mar 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes code that uses this library less dependent on specific imports.