Skip to content

Modernize Install#157

Merged
anacso17 merged 9 commits intomasterfrom
dev/maint/modernize-install
Dec 4, 2025
Merged

Modernize Install#157
anacso17 merged 9 commits intomasterfrom
dev/maint/modernize-install

Conversation

@fernandohds564
Copy link
Contributor

This PR modernizes the installation of mathphys, according to what was discussed in lnls-sirius/scripts#180.

I also removed the use of pkg_resources, since it was also deprecated.

I also removed the import of trackcpp in setup.py to check if it is installed. For two reasons:

  • this kind of checking is generally delegated to the builder, via the dependencies argument.
  • by default, modern versions of pip builds de package in a separate environment, that does not have trackcpp installed, raising an error when the setup.py module is imported. I don't know which version of pip adopted this behavior, but it used to work on our versions from python3.6. In order to circumvent this error, we would have to call pip --no-build-isolation in our Makefile. I decided go modernize/standardize this behavior to keep things simple and close to the default behavior.

Co-authored-by: Murilo B. Alves <murilo.alves@lnls.br>
@anacso17 anacso17 merged commit a5315f2 into master Dec 4, 2025
@anacso17 anacso17 deleted the dev/maint/modernize-install branch December 4, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants