Merged
Conversation
Gabrielrezende-asc
requested review from
fernandohds564,
vellosok75 and
xresende
fernandohds564
approved these changes
Aug 1, 2025
vellosok75
approved these changes
Aug 1, 2025
xresende
reviewed
Aug 8, 2025
| src_point_angle = 3.2e-3 # [rad] - at SI-01C1:MA-B1 for Carcará. | ||
| src_point_angle = 3.0e-3 # [rad] - at SI-01C1:MA-B1 for Carcará. | ||
|
|
||
| segtypes = { |
Contributor
There was a problem hiding this comment.
@Gabrielrezende-asc , take this opportunity to add a comment saying that the half segmented model for each magnet is downstream from its longitudinal center (i should have done it years ago).
Contributor
There was a problem hiding this comment.
also, add a #NOTE saying that additional information from the beamline regarding how to ascertain the source point angles will be provided by WHO in the future.
xresende
approved these changes
Aug 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.