Conversation
xresende
changed the title
murilobalves
approved these changes
Jul 5, 2021
anacso17
approved these changes
Jul 5, 2021
fernandohds564
approved these changes
Jul 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed a lurking bug with how kickmaps were used. This bug showed up only when distinct kickmaps were used, depending on the c++ compile version/implementation.
previously each Element object had a Kicktable pointer to the corresponding kicktable object. These kicktable objects are added to a Kicktable vector when a new one is defined. It turned out that, depending on the version of the C++ compiler, when a new kicktable object is added to the vector, previous ones could have their objects moved in memory, thus receiving a new object pointer and thus invalidating pointers registered in Element objects.
Instead of using a Kicktable pointer now the index into the vector is registered instead.