Conversation
fernandohds564
approved these changes
Sep 6, 2022
murilobalves
approved these changes
Sep 6, 2022
Contributor
|
thanks @jquentino. I'll make a PR in pyaccel reverting the changes that temporarily turn off quantum excitation while calculating the closed orbit too. |
xresende
approved these changes
Sep 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the quantum excitation is on, the tracking algorithms can't find 4D and 6D orbits, the same happens for the find one turn matrices algorithms. In a failed attempt to avoid this problem, I added in Pyaccel some lines to temporarily turn off the quantum excitation when computing the orbit by the
find_orbitfunction (lnls-fac/pyaccel#113).However, the Pyaccel
calc_twissdirectly uses the Trackcppfind_orbitfunctions instead of the Pyaccel ones, which introduces a bug because the first hasn't had the mechanism of temporarily turning off the quantum excitation implemented on it. This PR changes Trackcpp find orbit and find one turn matrices functions to fix this bug by implementing the above-described mechanism.