Skip to content

chore: add release script#2

Merged
raphapr merged 4 commits into
masterfrom
chore/release-script
Jun 27, 2025
Merged

chore: add release script#2
raphapr merged 4 commits into
masterfrom
chore/release-script

Conversation

@raphapr
Copy link
Copy Markdown

@raphapr raphapr commented Jun 27, 2025

Motivation and context for the change

This PR introduces a release script that automates the creation of a custom release based on an official Teleport CE release. The script applies a patch to add a CircleCI configuration, triggers the pipeline to compile binaries, and pushes the resulting image to the Loadsmart private registry.

make -C loadsmart release VERSION=x.y.z

PLATFORM-6535

A clear description of the change

  • add release script
  • remove sentinel job to prevent patch conflicts
  • update README

Testing

  • The change is covered with automated tests

Testing instructions

Rollback

  • The change can be automatically rolled back

Rollback instructions

@raphapr raphapr marked this pull request as ready for review June 27, 2025 14:00
@raphapr raphapr requested a review from a team as a code owner June 27, 2025 14:00
@raphapr raphapr merged commit 3ac25af into master Jun 27, 2025
5 checks passed
@raphapr raphapr deleted the chore/release-script branch June 27, 2025 17:19
raphapr added a commit that referenced this pull request Jun 27, 2025
* add release script

* remove sentinel job to prevent patch conflicts

* update README

* ensure version string is prefixed with 'v' if missing
raphapr added a commit that referenced this pull request Jun 30, 2025
* add release script

* remove sentinel job to prevent patch conflicts

* update README

* ensure version string is prefixed with 'v' if missing
raphapr added a commit that referenced this pull request Jul 10, 2025
* add release script

* remove sentinel job to prevent patch conflicts

* update README

* ensure version string is prefixed with 'v' if missing
raphapr added a commit that referenced this pull request Jul 10, 2025
* add release script

* remove sentinel job to prevent patch conflicts

* update README

* ensure version string is prefixed with 'v' if missing
raphapr pushed a commit that referenced this pull request Jul 10, 2025
…48008)

* Always attempt desktop discovery, even if LDAP is not ready

If Teleport loses it's connection to the LDAP server, it will
attempt to initiate a new condition when:

1. The user tries to connect to a desktop and Teleport fails
   to obtain the user's SID.
2. The periodic desktop discovery routine attempts to search
   LDAP for desktops.

In some circumstances, #2 never gets the chance to apply, since
discovery is skipped when LDAP is not ready. Additionally, if
LDAP is not ready, then you can't connect to a desktop, so #1
can't happen either, which means Teleport won't connect again
until it is restarted.

* Periodically use the LDAP connection when discovery is not enabled

If LDAP-based discovery is not enabled then we may go long periods
of time without trying to use the LDAP connection, which prevents
us from detecting disconnects (and restoring the connection) in a
timely manner.

When discovery is disabled, perform a read every 5 minutes and
reconnect if we detect a connection problem.

* Address review comments

* Fix some LDAP connection bugs

In gravitational#36281 we made some improvements to the LDAP reconnect behavior.
These changes considered the case where we had a connection to the
LDAP server but then got disconnected. They did not consider the case
where we never succesfully established a connection at all.

* Fix typo

---------

Co-authored-by: Gus Luxton <gus@goteleport.com>
raphapr added a commit that referenced this pull request Jul 10, 2025
* add release script

* remove sentinel job to prevent patch conflicts

* update README

* ensure version string is prefixed with 'v' if missing
raphapr added a commit that referenced this pull request Jul 18, 2025
* add release script

* remove sentinel job to prevent patch conflicts

* update README

* ensure version string is prefixed with 'v' if missing
raphapr added a commit that referenced this pull request Jul 24, 2025
* add release script

* remove sentinel job to prevent patch conflicts

* update README

* ensure version string is prefixed with 'v' if missing
raphapr added a commit that referenced this pull request Aug 5, 2025
* add release script

* remove sentinel job to prevent patch conflicts

* update README

* ensure version string is prefixed with 'v' if missing
raphapr added a commit that referenced this pull request Aug 5, 2025
* add release script

* remove sentinel job to prevent patch conflicts

* update README

* ensure version string is prefixed with 'v' if missing
felipeasantos pushed a commit that referenced this pull request Oct 3, 2025
…eads and writes (gravitational#57815)

Attempt #2. Read requests for a given copy operation can arrive out of order. Adjusted this approach to record all read/write events within a given time period, then find the longest contiguous set of reads/writes that can be joined into a single audit event before emitting  audit event(s).

bit of cleanup

A bit of code cleanup plus extra test case. Removed timestamps from testing since the compaction algorithm can't really guarantee which segments will get grouped together.

Fix racy tests by bringing assertions into synctest bubble and using 'flush' for syncronization. Also add more thorough test cases for timer expiration and flush behavior.

lint fixes

Add license header

Replace unnecessary sort with 'slices.Min'

Apply suggestions from code review

Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>

Rename 'evnt' -> 'event'

Return iterator instead of slice

Abandon 'stream' terminology in favor of 'fileOperationsBucket'. This might be a better name since the code is basically sorting audit events  into a set of 'buckets' and attempting to compact each bucket of events later on.

Add a few comments
raphapr pushed a commit that referenced this pull request Oct 3, 2025
…eads and writes (gravitational#58446)

Attempt #2. Read requests for a given copy operation can arrive out of order. Adjusted this approach to record all read/write events within a given time period, then find the longest contiguous set of reads/writes that can be joined into a single audit event before emitting  audit event(s).

bit of cleanup

A bit of code cleanup plus extra test case. Removed timestamps from testing since the compaction algorithm can't really guarantee which segments will get grouped together.

Fix racy tests by bringing assertions into synctest bubble and using 'flush' for syncronization. Also add more thorough test cases for timer expiration and flush behavior.

lint fixes

Add license header

Replace unnecessary sort with 'slices.Min'

Apply suggestions from code review

Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>

Rename 'evnt' -> 'event'

Return iterator instead of slice

Abandon 'stream' terminology in favor of 'fileOperationsBucket'. This might be a better name since the code is basically sorting audit events  into a set of 'buckets' and attempting to compact each bucket of events later on.

Add a few comments
raphapr added a commit that referenced this pull request Oct 3, 2025
* add release script

* remove sentinel job to prevent patch conflicts

* update README

* ensure version string is prefixed with 'v' if missing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants