BILL-5586: Add descriptor_code support to bank account verification#308
BILL-5586: Add descriptor_code support to bank account verification#308kevinpjones wants to merge 3 commits into
Conversation
Stripe updated microdeposit verification from two amounts to a single 6-character descriptor code. The Node SDK is a pass-through wrapper so no model changes are needed — this adds fixture and test coverage for the new path and exposes microdeposit_type in the BANK_ACCOUNT fixture. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds tests for verifying bank accounts using a descriptor code and introduces assertions to verify the behavior of the new microdeposit_type field, which is set to null once an account is verified. The review feedback points out that several callback-based tests ignore error parameters, which can lead to cryptic failures or timeouts. It is recommended to explicitly handle these errors by passing them to the done callback.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 participant
Description
Problem: Stripe's Setup Intents API added a descriptor code-based microdeposit verification path alongside the legacy two-amount path. When a bank account is created via Setup Intents, Stripe sends a single $0.01 deposit whose statement descriptor contains a 6-character code beginning with
SM. The Node SDK had no test coverage for this path, and theBANK_ACCOUNTfixture was missingmicrodeposit_type, so the response shape didn't reflect the real API.Solution: Added
microdeposit_typeto theBANK_ACCOUNTfixture and added test coverage for:descriptor_code(new path)amounts(existing path — renamed test for clarity)microdeposit_typepresent on a retrieved (unverified) bank accountmicrodeposit_typeisnullonce an account is verifiedNon-breaking: The Node SDK is a pure pass-through wrapper —
descriptor_codealready routes correctly throughURLSearchParamswith no model-layer changes needed. All existing code usingamountscontinues to work without any changes.Story
https://lobsters.atlassian.net/browse/BILL-5586 (subtask of https://lobsters.atlassian.net/browse/BILL-5581)
Related PR's
Mirrors lob/lob-php#192
Verify