Remove states,countries,postcard.message#165
Merged
Conversation
hwrdprkns
changed the title
mgartner
suggested changes
Oct 30, 2017
mgartner
left a comment
mgartner
left a comment
There was a problem hiding this comment.
Looks good. A couple more things to remove:
https://github.com/lob/lob-ruby/blob/hwrd-deprecate/lib/lob/client.rb#L61-L63
https://github.com/lob/lob-ruby/blob/hwrd-deprecate/lib/lob/client.rb#L41-L43
There's a few mentions of state and countries in README.md
hwrdprkns
force-pushed
the
hwrd-deprecate
branch
from
08fc129 to
995953f
Compare
Author
|
Correct - f'd that up when trying to split the changes into two commits locally |
hwrdprkns
force-pushed
the
hwrd-deprecate
branch
from
995953f to
7ec1f32
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Remove the states api, countries api, and postcard.message field
Why: Newest API version deprecates those