Feature: Address restriction

[Adnan-cds]

Additions:

• A Webform Options config entity that lists Local custodian codes.
• Programmatic addition of the above.
• A local custodian code selector for the Address lookup Webform element.
• Passes on the local custodian code to all relevant Geocoder plugins.

Closes #45

[ekes]

Don't know if this is helpful for your passing to gecoders, but I've got a MR https://www.drupal.org/project/geocoder/issues/3406303 so you can pass a query directly to the geocoder plugin - and hence set additional parameters on the query (often setData() is used for passing custom restrictions etc. that a geocoder supports).

[Adnan-cds]

but I've got a MR https://www.drupal.org/project/geocoder/issues/3406303

Hi Ekes,
Very useful feature. Thanks for pointing out. I will surely take a look :)

[Adnan-cds]

Ready for review. Uses the recently added "additional parameter passing to geocoders" feature of the geocoder module.

Test steps

• Add the "LocalGov address lookup" element to a Webform.
• While configuring the "Address lookup" element, select a Local authority:
• If the address lookup element is using the "Localgov OS Places" geocoder, subsequent address lookups will remain limited to the selected local authority. All other geocoders should remain unaffected. "Sandown" is a good test candidate street name.

Resolves #45

[ekes]

Are the custodian codes going to be useful for https://github.com/localgovdrupal/localgov_os_places_geocoder_provider to be used in other geocoding?

[Adnan-cds]

Are the custodian codes going to be useful for

I think so. The latest code change in the OS Places geocoder added support for the Local custodian code.

[finnlewis]

So what's the plan here @Adnan-cds ? Move some config to other localgov modules or keep it here?

[Adnan-cds]

So what's the plan here?

Let's see what Ekes thinks. We can move the Local custodian code configuration to localgov_geo. But then it would become site-wide rather than specific to a form element.

[andybroomfield]

Form builders will still need to set this in the form as sometimes we want an address for Brighton & Hove only and sometimes we want a UK wide address.

[finnlewis]

Discussion in Merge Tuesday:

• Ekes: was just thinking of moving the custodian codes table to a more generic place. Could we have a call back?
• Ekes But no objections to merging this and creating a new issue / merge request to change the source of custodian codes.

[finnlewis]

Sounds like there are no objections to merging this now and addressing the custodian codes move in another issue.

[Adnan-cds]

Thanks. I have just raised a ticket to explore the use of a callback to source the custodian codes.