This repository was archived by the owner on Mar 17, 2026. It is now read-only.
nodejs20.x - migrate sample from aws-sdk v2 to v3#10
Merged
sannya-singal merged 6 commits intomainfrom May 22, 2024
Merged
Conversation
steffyP
approved these changes
May 21, 2024
steffyP
left a comment
There was a problem hiding this comment.
Great work, @sannya-singal 🙌 🚀 Nice to see the sample working with Nodejs 20 🎉
I only have two questions:
- when running the action, there are still some warnings, e.g.
Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
I think we should use actions/checkout@v4 and actions/setup-python@v5 .
Could you test this, and see if there are still warnings? 🙏
- Not related to this PR, just something I stumbled across: There seem to be some changes in your private repo (where this one was forked from), that is not in the localstack-sample yet. Could you create a PR if the change is relevant?
Author
|
Thanks @steffyP for the review 🙌 🙇♀️ I have removed all the soon to be deprecated github actions in the repository and updated the ones giving warnings, also changed the serverless version to use Regarding the forked repo diff, its already included in here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The current transcription sample is not compatible with the latest node version.
Changes
This PR: