Skip to content

Conversation

@merowinger92
Copy link
Contributor

Replicating the Pull Request from Serverless Localstack Wrapper:

Copy link
Member

@whummer whummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks for fixing this @merowinger92 ! 🚀

My only feedback would be that we could cache the local endpoint once it's been resolved (by using some global variable), as getLocalHost(..) is called several times during the execution lifecycle. Do you think we could still add that as part of this PR?

Also, would be great if you could bump the version in package.json and add a short note to the Change Log section in the README, so we can release this right away. Thanks! 🙌

(Side note: failing Go integration test seems to be unrelated to these changes, we'll look into that separately..)

/cc @dominikschubert

@merowinger92 merowinger92 force-pushed the mk-78-ipv6-macos branch 2 times, most recently from 73cf16d to bc8947f Compare January 27, 2023 12:35
@merowinger92
Copy link
Contributor Author

Hi @whummer!

I adapted the PR with your remarks.

Fixes #78

Copy link
Member

@whummer whummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for the quick turnaround! We'll release this to npm right away.. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants