forked from aws/aws-lambda-runtime-interface-emulator
-
Notifications
You must be signed in to change notification settings - Fork 2
feat: Integrate with upstream #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
fcbb59f
chore(deps): Update to Go 1.24 (#143)
roger-zhangg 41da780
chore(deps): Update go-chi to v5.2.2 (#149)
mbfreder 8562f80
Update README.md to make it clear RIE binary is meant to be used in l…
roger-zhangg 5d7c7ec
feat(Multi-tenancy): Add support for multi-tenancy
licjun aae9602
feat: add support for Lambda Managed Instance (LMI) functions (#158)
vicheey 94b1ec7
chore: migrate to new repo structure
gregfurman 352adb7
feat: apply relevent changes
gregfurman c6aebd0
fix: skip tests with incorrect error message
gregfurman eb45a2c
Revert attribute name and util usage changes
gregfurman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| package agents | ||
|
|
||
| import ( | ||
| "log/slog" | ||
| "path" | ||
| "path/filepath" | ||
|
|
||
| "github.com/aws/aws-lambda-runtime-interface-emulator/internal/lambda-managed-instances/utils" | ||
| ) | ||
|
|
||
| const ( | ||
| ExtensionsDir = "/opt/extensions" | ||
| ) | ||
|
|
||
| func ListExternalAgentPaths(fileutils utils.FileUtil, dir string, root string) []string { | ||
| var agentPaths []string | ||
| if !isCanonical(dir) || !isCanonical(root) { | ||
| slog.Warn("Agents base paths are not absolute and in canonical form", "dir", dir, "root", root) | ||
| return agentPaths | ||
| } | ||
| fullDir := path.Join(root, dir) | ||
| files, err := fileutils.ReadDirectory(fullDir) | ||
| if err != nil { | ||
| if fileutils.IsNotExist(err) { | ||
| slog.Info("The extension's directory does not exist, assuming no extensions to be loaded", "fullDir", fullDir) | ||
| } else { | ||
|
|
||
| slog.Error("Cannot list external agents", "err", err) | ||
| } | ||
|
|
||
| return agentPaths | ||
| } | ||
|
|
||
| for _, file := range files { | ||
| if !file.IsDir() { | ||
|
|
||
| p := path.Join("/", dir, file.Name()) | ||
| agentPaths = append(agentPaths, p) | ||
| } | ||
| } | ||
| return agentPaths | ||
| } | ||
|
|
||
| func isCanonical(path string) bool { | ||
| absPath, err := filepath.Abs(path) | ||
| return err == nil && absPath == path | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch 👍
So we basically need to change the imports to our fork instead of using upstream via
go.amzn.com. I guess these imports might be a frequent area of conflict, so it's worth documenting the rationale in our LocalStack readme.