Skip to content

fix(missing user): changed logic to get users#33

Merged
HarshCasper merged 3 commits intomainfrom
missing-user-fix
Apr 13, 2023
Merged

fix(missing user): changed logic to get users#33
HarshCasper merged 3 commits intomainfrom
missing-user-fix

Conversation

@Pive01
Copy link
Copy Markdown
Collaborator

@Pive01 Pive01 commented Apr 6, 2023

Closes #31

@Pive01 Pive01 requested a review from whummer April 6, 2023 08:26
Copy link
Copy Markdown
Member

@whummer whummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 Thanks for the fix @Pive01 . Unable to test this myself (no access to Windows machine right now), but based on the bug and the PR description it seems to me that should work.

/cc @lukqw @HarshCasper

Comment thread ui/src/services/util/format.ts Outdated
Co-authored-by: Waldemar Hummer <waldemar.hummer@gmail.com>
@valeryan
Copy link
Copy Markdown

Hope this works, I have been unable to use the localstack extension because it can't find my user.

@HarshCasper HarshCasper merged commit b6281ec into main Apr 13, 2023
@lukqw lukqw deleted the missing-user-fix branch April 13, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

User not available when configuring default mount point settings

4 participants