Import boto3 different name #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It helps to patch `boto3.client` in other source codes.
Member
|
Thanks for this enhancement @smatsumt . 👍 We'll release a new version to pypi shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request change
import boto3.sessionwithfrom boto3 import session as session_.It makes easy to patch
boto3.clientandboto3.resourcecall in other source code.In original implementation, we can not patch
boto3.clientwithlocalstack.session.Session().clientbecauselocalstack.sessionalso usesboto3.clientand it ends with RecursionError.Importing
boto3.clientwith different name will not cause such error when we patchboto3.client.I also added a simple patching sample in README.md Usage section. This PR may relate with Issue #6