Consider AWS_ENDPOINT_URL configuration when resolving service endpoints
#46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds minor enhancements to have proper handling of the
AWS_ENDPOINT_URLconfiguration. Previously we were only using it for theget_service_endpoint(..)function, but not forget_service_endpoints(..). This was leading to issues when using theSummary of changes:
AWS_ENDPOINT_URLinto get_service_endpoints(..)get_service_endpoints(..)fromget_service_endpoint(..), and select the corresponding service entry from the dict. There is a tiny performance penalty in this approach, which seems acceptable given that it allows us to keep the endpoint construction logic in a central place. (this now also works transitively forget_service_ports(..))$AWS_ENDPOINT_URLconfigurationSide note: Overall, this library (esp. the host/port handling bit) should soon become obsolete (there's already a draft PR to remove it from LocalStack core, and we should eliminate it from
awslocalsoon as well).