This repository was archived by the owner on Mar 23, 2026. It is now read-only.
fix sqs dev endpoint to show invisible fifo messages correctly#13196
Merged
fix sqs dev endpoint to show invisible fifo messages correctly#13196
Conversation
LocalStack Community integration with Pro 2 files ± 0 2 suites ±0 1h 2m 49s ⏱️ - 55m 58s Results for commit c55ddfe. ± Comparison against base commit f93ee95. This pull request removes 1592 and adds 3 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Test Results (amd64) - Integration, Bootstrap 5 files ± 0 5 suites ±0 1h 32m 6s ⏱️ - 1h 6m 25s Results for commit c55ddfe. ± Comparison against base commit f93ee95. This pull request removes 1942 and adds 3 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
baermat
approved these changes
Sep 26, 2025
Member
baermat
left a comment
There was a problem hiding this comment.
Thanks for tackling this! A go from my side, once my question is addressed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This fixes a long-standing issue of the
/_aws/sqs/messagesendpoint not showing invisible messages correctly of FIFO queues. The issue was that we still made the assumption thatqueue.inflightholds all inflight messages. This is no longer true since fix message group id behavior in sqs fifo queues, since we reworked the way fifo queues keep track of inflight messages in #8238.I slightly change how the messages are collected for fifo queues, and now it works.
Changes
/_aws/sqs/messagesendpoint now correctly lists in-flight messages for FIFO queues