DDB: regenerate snapshots for WarmThroughput#13257
Conversation
bentsku
added
aws:dynamodb
This reverts commit 6c8d6fa.
Test Results - Alternative Providers676 tests 416 ✅ 33m 49s ⏱️ Results for commit ef6db2a. ♻️ This comment has been updated with latest results. |
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 2h 39m 4s ⏱️ Results for commit ef6db2a. ♻️ This comment has been updated with latest results. |
bentsku
added
the
review: merge when ready
bentsku
requested review from
dfangl,
dominikschubert,
gregfurman,
joe4dev,
pinzon and
simonrw
as code owners
| def check_esm_active(): | ||
| return aws_client.lambda_.get_event_source_mapping(UUID=uuid)["State"] != "Creating" | ||
|
|
||
| assert wait_until(check_esm_active) |
There was a problem hiding this comment.
❓ Any particular reason why we cannot use _await_event_source_mapping_enabled here?
| ) | ||
| @markers.aws.validated | ||
| def test_event_source_mapping_lifecycle( | ||
| def test_event_source_mapping_lifecycle_delete_function( |
There was a problem hiding this comment.
❓ I didn't fully understand these changes in lifecycle and lifecycle_delete_function (might be a git diff issue) 🤔 It kinda looks like swapping the order.
There was a problem hiding this comment.
Yes, this is really weird! I haven't touched this code at all, looks like a git diff issue! Same for the question/comment above, I haven't touched it and it must be the old code moving up. Very weird indeed
2 participants
Motivation
Follow up from #13235, the test selection didn't pick up some Lambda tests and CloudFormation.
Regenerated the snapshots, took the opportunity to remove some old skips.
DynamoDB isn't listed as a hard dependency of Lambda, only DynamoDB Streams. As we don't want to string along all dependencies of dependencies in our test selection, this is somewhat expected behavior. As it seems DynamoDB is actually quite heavily tied to Lambda, maybe we should declare it as an optional dependency (this is a different dependency than say SNS and SQS). In order to quickly fix the issue, this PR does not consider the root cause and I'll look into a follow-up PR to make sure this doesn't happen again (at least on the lambda side, CFN is a different, known thing)
Changes