-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
IaC: fix problematic CFN plugin manager import #13621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for jumping on this!
We'll need to think more thoroughly about the upstream resources as well with this, and maybe deferring this import even further by making this a cached property instead of a static method we call once. But this can be a follow-up, let's unblock ourselves for now!
edit: there's also the issue of importing service code outside of the service itself, but we can think about that later. If we only have CloudFormation calling this code, then it would be fine. More argument towards deferring the import until CloudFormation itself calls this code/makes use of it 👍
Thank you and @dfangl for identifying the issue!
Good point, will follow-up on this 👍 |
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 2h 35m 36s ⏱️ Results for commit 10695c5. |
Motivation
The PR #13597 introduced changes which caused side-effects in another repository. This PR fixes problematic import by moving it to function level.
Changes
Relates to FLC-80