Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Align SFN store to conventions#13887

Merged
giograno merged 1 commit into
mainfrom
sfn-store-module
Mar 5, 2026
Merged

Align SFN store to conventions#13887
giograno merged 1 commit into
mainfrom
sfn-store-module

Conversation

@giograno
Copy link
Copy Markdown
Member

@giograno giograno commented Mar 5, 2026

Motivation

By convention, we keep the store definition in a models module inside the service package.
Some workflows depend on this assumption. SFN violates this assumption.

Changes

  • Rename store.py to models.py.

@giograno giograno added semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Mar 5, 2026
@giograno giograno requested a review from bentsku March 5, 2026 11:20
@giograno giograno self-assigned this Mar 5, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 5, 2026

Test Results - Preflight, Unit

23 104 tests  ±0   21 217 ✅ ±0   6m 11s ⏱️ -5s
     1 suites ±0    1 887 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit cd6e4cf. ± Comparison against base commit 7106180.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 5, 2026

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   21m 45s ⏱️ - 1h 43m 11s
1 747 tests  - 3 607  1 658 ✅  - 3 321  89 💤  - 282  0 ❌ ±0 
1 749 runs   - 3 607  1 658 ✅  - 3 321  91 💤  - 282  0 ❌ ±0 

Results for commit cd6e4cf. ± Comparison against base commit 7106180.

This pull request removes 3607 tests.
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 5, 2026

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 3s ⏱️ -1s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit cd6e4cf. ± Comparison against base commit 7106180.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 5, 2026

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   39m 30s ⏱️
1 771 tests 1 683 ✅ 88 💤 0 ❌
1 777 runs  1 683 ✅ 94 💤 0 ❌

Results for commit cd6e4cf.

Copy link
Copy Markdown
Contributor

@bentsku bentsku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix 🙏

@giograno giograno marked this pull request as ready for review March 5, 2026 18:12
@giograno giograno merged commit 914e95e into main Mar 5, 2026
49 checks passed
@giograno giograno deleted the sfn-store-module branch March 5, 2026 18:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants