This repository was archived by the owner on Mar 23, 2026. It is now read-only.
Align SFN store to conventions#13887
Merged
Merged
Conversation
LocalStack Community integration with Pro 2 files ± 0 2 suites ±0 21m 45s ⏱️ - 1h 43m 11s Results for commit cd6e4cf. ± Comparison against base commit 7106180. This pull request removes 3607 tests. |
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 39m 30s ⏱️ Results for commit cd6e4cf. |
bentsku
approved these changes
Mar 5, 2026
Contributor
bentsku
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fix 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
By convention, we keep the store definition in a
modelsmodule inside the service package.Some workflows depend on this assumption. SFN violates this assumption.
Changes
store.pytomodels.py.