Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Unable to build localstack with make docker-build#6899

Merged
dfangl merged 3 commits intolocalstack:masterfrom
sha-shrestha:master
Oct 3, 2022
Merged

Unable to build localstack with make docker-build#6899
dfangl merged 3 commits intolocalstack:masterfrom
sha-shrestha:master

Conversation

@sha-shrestha
Copy link
Copy Markdown
Contributor

This addresses #6881

Copy link
Copy Markdown
Contributor

@localstack-bot localstack-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to LocalStack! Thanks for raising your first Pull Request and landing in your contributions. Our team will reach out with any reviews or feedbacks that we have shortly. We recommend joining our Slack Community and share your PR on the #community channel to share your contributions with us. Please make sure you are following our contributing guidelines and our Code of Conduct.

@localstack-bot
Copy link
Copy Markdown
Contributor

localstack-bot commented Sep 20, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@sha-shrestha
Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Copy Markdown
Member

@dfangl dfangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no problem with replacing source with the POSIX alternative, so thank you for this PR! I added a description of the underlying reason and how to probably fix it here: #6881 (comment) .

@dfangl dfangl merged commit 4b8318e into localstack:master Oct 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants