Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Use docker compose as fallback if docker-compose is not available#8734

Merged
dfangl merged 1 commit into
masterfrom
fix-compose-validate
Jul 21, 2023
Merged

Use docker compose as fallback if docker-compose is not available#8734
dfangl merged 1 commit into
masterfrom
fix-compose-validate

Conversation

@dfangl
Copy link
Copy Markdown
Member

@dfangl dfangl commented Jul 21, 2023

Motivation

Since docker compose v2 is available, for many systems, docker-compose is not available any more (and not aliased to docker compose).

For these, we have to have a fallback to docker compose.

Fixes #8732

Changes

  • Use docker compose instead of docker-compose if the latter is not available.

@dfangl dfangl requested a review from alexrashed July 21, 2023 11:27
@dfangl dfangl marked this pull request as ready for review July 21, 2023 11:27
Copy link
Copy Markdown
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! The fix is looking good, thanks for jumping on this! 🚀

@dfangl dfangl added the semver: patch Non-breaking changes which can be included in patch releases label Jul 21, 2023
@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 82.327% (+0.003%) from 82.324% when pulling cdbf9b4 on fix-compose-validate into 93dd6f7 on master.

@github-actions
Copy link
Copy Markdown

LocalStack Community integration with Pro

       2 files         2 suites   1h 24m 57s ⏱️
2 245 tests 1 903 ✔️ 342 💤 0
2 246 runs  1 903 ✔️ 343 💤 0

Results for commit cdbf9b4.

@dfangl dfangl merged commit 27edb72 into master Jul 21, 2023
@dfangl dfangl deleted the fix-compose-validate branch July 21, 2023 12:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: localstack config validate: Errno 2 no such file or directory: 'docker-compose'

3 participants