This repository was archived by the owner on Mar 23, 2026. It is now read-only.
Further enhance parity of API Gateway patch operations#8873
Merged
Conversation
bentsku
approved these changes
Aug 9, 2023
Contributor
bentsku
left a comment
bentsku
left a comment
There was a problem hiding this comment.
LGTM! Awesome to see even more parity, especially those patches being removed... 🙏
Sorry I missed the missing commas in the previous review introducing the regression 😬 but good catch finding it so quickly!
Comment on lines
+884
to
+886
| # note: weird formatting in AWS - required for snapshot testing | ||
| valid_paths = valid_paths.replace("/burstLimit, /", "/burstLimit /") | ||
| valid_paths = valid_paths.replace("/rateLimit, /", "/rateLimit /") |
Contributor
There was a problem hiding this comment.
such a weird bug, good catch!
bentsku
added
the
semver: patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Further enhance parity of API Gateway patch operations. Follow-up from #8836. Addresses #8739 Unfortunately, #8836 introduced a regression where certain fields of Stages cannot be updated now.
In the process of more snapshot testing, I've discovered a few more discrepancies in the moto logic, which are also fixed in this PR (and some obsolete moto patches removed).
Changes
/*/*/throttling/burstLimitstage attributes