This repository was archived by the owner on Mar 23, 2026. It is now read-only.
Ensure properly configured client for fixtures and testutils#8892
Merged
Conversation
viren-nadkarni
added
semver: minor
viren-nadkarni
requested review from
calvernaz,
dfangl,
dominikschubert,
giograno and
joe4dev
as code owners
viren-nadkarni
removed request for
calvernaz,
dfangl,
dominikschubert and
joe4dev
giograno
approved these changes
Aug 17, 2023
|
|
||
| def get_rest_api_paths(rest_api_id, region_name=None): | ||
| apigateway = connect_to(region_name=region_name).apigateway | ||
| def get_rest_api_paths(account_id: str, region_name: str, rest_api_id): |
Member
There was a problem hiding this comment.
nit/question: regione_name was optional and now it's not. Do we always expect it or it can be None?
rest_api_id might get a str type hint.
Member
Author
There was a problem hiding this comment.
It can be None from the perspective of the internal client library (connect_to). However, we want to be as explicity as possible with account IDs and regions to keep expectable behaviour with cross-account usage :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR make a few fixes to usage of the internal clients to make use of proper account ID/region from request context.
This is part of the continuing effort to improve cross account namespacing in LocalStack.