This repository was archived by the owner on Mar 23, 2026. It is now read-only.
Add resource provider for AWS::SQS::QueuePolicy#8989
Merged
Conversation
dominikschubert
requested review from
baermat,
pinzon,
simonrw and
thrau
as code owners
dominikschubert
added
the
semver: patch
simonrw
approved these changes
Aug 25, 2023
thrau
reviewed
Aug 28, 2023
Comment on lines
+71
to
+74
| """ | ||
| Fetch resource information | ||
| """ | ||
| raise NotImplementedError |
Member
Author
There was a problem hiding this comment.
Not in use currently. Just aiming to migrate a few resources from their GenericBaseModel implementation to a "raw" ResourceProvider one.
thrau
approved these changes
Aug 28, 2023
Member
thrau
left a comment
thrau
left a comment
There was a problem hiding this comment.
LGTM! just wondering why we don't have read implemented
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We already enabled the AWS::SQS::Queue resource provider, so I thought it might be a good idea to "finish" the service by migrating the only other remaining CFn model for SQS
Changes
AWS::SQS::QueuePolicy