This repository was archived by the owner on Mar 23, 2026. It is now read-only.
Add test for s3 bucket concurrency#9072
Merged
Merged
Conversation
dfangl
added
the
semver: patch
bentsku
approved these changes
Sep 5, 2023
Contributor
bentsku
left a comment
bentsku
left a comment
There was a problem hiding this comment.
LGTM! Nice changes, and cool test! Barrier 😎
bentsku
suggested changes
Sep 5, 2023
Contributor
bentsku
left a comment
bentsku
left a comment
There was a problem hiding this comment.
Oops, I've missed something. We're not cleaning up the buckets we've created 😬
bentsku
reviewed
Sep 5, 2023
|
|
||
|
|
||
| class TestParallelBucketCreation: | ||
| @markers.aws.unknown |
Contributor
There was a problem hiding this comment.
Suggested change
| @markers.aws.unknown | |
| @markers.aws.only_localstack |
bentsku
approved these changes
Sep 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We had some problem with simultaneous bucket operations. This PR adds a test for it. It should be fixed with #9044
Changes