Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

cdk provisioning improvements for testing#9081

Merged
steffyP merged 3 commits into
masterfrom
provisioning_improvments
Sep 7, 2023
Merged

cdk provisioning improvements for testing#9081
steffyP merged 3 commits into
masterfrom
provisioning_improvments

Conversation

@steffyP
Copy link
Copy Markdown
Member

@steffyP steffyP commented Sep 6, 2023

Motivation

Some improvements for the provisioning.

Changes

  • add optional parameter delete_bucket for the cleanup_s3_bucket helper
  • don't assume stack-name exists for get_stack_outputs

@steffyP steffyP added the semver: patch Non-breaking changes which can be included in patch releases label Sep 6, 2023
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 6, 2023

LocalStack Community integration with Pro

       2 files         2 suites   1h 27m 34s ⏱️
2 169 tests 1 671 ✔️ 498 💤 0
2 170 runs  1 671 ✔️ 499 💤 0

Results for commit 0689960.

♻️ This comment has been updated with latest results.

@steffyP steffyP marked this pull request as ready for review September 6, 2023 15:43
Comment thread localstack/testing/scenario/provisioning.py Outdated
Copy link
Copy Markdown
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread localstack/testing/scenario/provisioning.py Outdated
Co-authored-by: Dominik Schubert <dominik.schubert91@gmail.com>
@steffyP steffyP merged commit 5473e68 into master Sep 7, 2023
@steffyP steffyP deleted the provisioning_improvments branch September 7, 2023 06:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants