Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

[SFN] Support for EventBridge#9123

Merged
MEPalma merged 3 commits into
masterfrom
MEP-sfn-events
Sep 13, 2023
Merged

[SFN] Support for EventBridge#9123
MEPalma merged 3 commits into
masterfrom
MEP-sfn-events

Conversation

@MEPalma
Copy link
Copy Markdown
Contributor

@MEPalma MEPalma commented Sep 12, 2023

Motivation

Adds support for EventBridge optimised integration.

Changes

Added state task resolver for EventBridge and relevant snapshot tests.

@MEPalma MEPalma added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Sep 12, 2023
@MEPalma MEPalma added this to the 2.3 milestone Sep 12, 2023
@MEPalma MEPalma self-assigned this Sep 12, 2023
@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 79.856% (-0.09%) from 79.945% when pulling 5325786 on MEP-sfn-events into 5557e15 on master.

@github-actions
Copy link
Copy Markdown

LocalStack Community integration with Pro

       2 files         2 suites   1h 17m 38s ⏱️
2 196 tests 1 705 ✔️ 491 💤 0
2 197 runs  1 705 ✔️ 492 💤 0

Results for commit 5325786.

Copy link
Copy Markdown
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

def _normalised_request_parameters(env: Environment, parameters: dict):
entries = parameters.get("Entries", [])
for entry in entries:
# Optimised integration for events automatically stringifies "Entries.Detail" if this is not a string,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great comments here 👍

@MEPalma MEPalma merged commit b93486d into master Sep 13, 2023
@MEPalma MEPalma deleted the MEP-sfn-events branch September 13, 2023 07:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants