This repository was archived by the owner on Mar 23, 2026. It is now read-only.
disable health check for default service providers#9202
Merged
Conversation
thrau
added
the
semver: minor
Contributor
|
Does this PR invalidate #9200? |
Member
Author
thanks for making me aware of that one. actually i suppose it would. your effort to fix this is much more admirable than what i'm doing 😄 but i think we should just get rid of them. |
alexrashed
approved these changes
Sep 22, 2023
Member
alexrashed
left a comment
alexrashed
left a comment
There was a problem hiding this comment.
Awesome! This will help decreasing the coupling with localstack-python even further. I think we can remove this legacy code with the next major release. 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
For legacy reasons, we used the
local_api_checkeras default health check. This made sense when we had backends running on different ports, but now almost all providers run in memory and not as backends, and those that require backends (like dynamodb), aren't considered anymore through the defaultlocal_api_checkerhealth check (since we basically just call:4566).Basically, doing health checks in this way makes no sense any more, and we can evaluate whether the concept as such makes sense and if so what we need to do to perform meaningful health checks.
I've seen errors related to these health checks in logs recently, and I think this is a good opportunity to get rid of them.
Changes
Service.for_provider(which is done in most cases), disable the health check