Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

fix welcome action by upgrading to github-script v6#9221

Merged
HarshCasper merged 1 commit into
masterfrom
fix-welcome-action
Sep 26, 2023
Merged

fix welcome action by upgrading to github-script v6#9221
HarshCasper merged 1 commit into
masterfrom
fix-welcome-action

Conversation

@alexrashed
Copy link
Copy Markdown
Member

Motivation

Unfortunately, #9068 broke the "Welcome First Time Contributors" GitHub action.
This PR upgraded the action from GitHub Script v2 to v6.
With GitHub Script v5, there were some breaking changes related to the REST operations on the github object.
More details can be found here: https://github.com/actions/github-script#breaking-changes-in-v5

Changes

  • Use github.rest.<rest-action> instead of github.<rest-action>.

/cc @HarshCasper

@alexrashed alexrashed added the semver: patch Non-breaking changes which can be included in patch releases label Sep 25, 2023
@alexrashed alexrashed added this to the 3.0 milestone Sep 25, 2023
@alexrashed alexrashed requested a review from thrau as a code owner September 25, 2023 14:54
@alexrashed alexrashed self-assigned this Sep 25, 2023
@alexrashed alexrashed requested a review from dfangl as a code owner September 25, 2023 14:54
@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 83.055% (+0.03%) from 83.022% when pulling ec7de68 on fix-welcome-action into 402450d on master.

@HarshCasper HarshCasper merged commit 26ca7e7 into master Sep 26, 2023
@alexrashed alexrashed deleted the fix-welcome-action branch September 26, 2023 05:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants