Merged
Conversation
gtsiolis
requested review from
anisaoshafi,
carole-lavillonniere and
silv-io
as code owners
anisaoshafi
approved these changes
Apr 22, 2026
Contributor
anisaoshafi
left a comment
anisaoshafi
left a comment
There was a problem hiding this comment.
LGTM, tested and looks good 🚀
Was thinking if the customers would expect restart to re-pull the image. If for some reasons we introduce some API changes (reflecting AWS changes or sth else), or different behaviours that previous to restart worked, can be confusing for the customer, plus the extra wait for docker pull.
I am in favour of upgrading though, just a random thought.
carole-lavillonniere
approved these changes
Apr 23, 2026
Collaborator
There was a problem hiding this comment.
Looks good 👏
Pushed a small commit to make sure we emit the telemetry events for the new command 76c77dc
Mirrors the stop test's pattern of checking both lstk_lifecycle and lstk_command events, since restart emits lifecycle events for both the stop and start phases.
carole-lavillonniere
force-pushed
the
des-206-implement-lstk-restart-command
branch
from
50a60a5 to
76c77dc
Compare
Member
Author
|
Thanks for adding commits and merging, @carole-lavillonniere! 🏀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
restartcommand that stops the running emulator and starts it again in a single command.The command runs the full stop and start lifecycle: stops the container, re-validates the auth token and license, pulls the image if needed, and waits for the health endpoint before returning. This ensures restart is always safe (no stale state, no skipped validation) rather than just bouncing the container.