Detect externally-named containers in AWS proxy commmnds#232
Merged
Conversation
gtsiolis
requested review from
anisaoshafi,
carole-lavillonniere and
silv-io
as code owners
anisaoshafi
approved these changes
May 7, 2026
Contributor
anisaoshafi
left a comment
anisaoshafi
left a comment
There was a problem hiding this comment.
Good catch, thanks for the prompt fix 👏🏼
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lstk aws ...reportedLocalStack AWS Emulator is not runningwhenever LocalStack was started outside lstk under a non-default container name (e.g. via thedocker composetemplate, where the container is namedlocalstack-main). Other commands —lstk(start),lstk status,lstk stop— already detect the running container in this case, so the inconsistency was confusing.Root cause:
cmd/aws.goonly checked Docker for the configured container name (rt.IsRunning(awsContainer.Name())) instead of falling back to image-based discovery the way the other commands do viaresolveRunningContainerName.Closes DES-220