Skip to content

Make start header more compact#257

Merged
carole-lavillonniere merged 1 commit into
mainfrom
des-233-make-start-header-more-compact
May 21, 2026
Merged

Make start header more compact#257
carole-lavillonniere merged 1 commit into
mainfrom
des-233-make-start-header-more-compact

Conversation

@gtsiolis
Copy link
Copy Markdown
Member

@gtsiolis gtsiolis commented May 20, 2026

This will...

  1. Replace verbose per-phase lines during start with a single in-place spinner.
  2. Surface license plan inline during license validation instead of leaving it implicit.
  3. Reword the final ready line from LocalStack ready to LocalStack is running.
BEFORE AFTER
Screenshot 2026-05-21 at 00 16 44 Screenshot 2026-05-21 at 00 16 07

@gtsiolis gtsiolis force-pushed the des-233-make-start-header-more-compact branch from e587314 to b982e2f Compare May 20, 2026 21:32
@carole-lavillonniere
Copy link
Copy Markdown
Collaborator

@claude review

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cosmetic/UX-only change: swap verbose status lines for a spinner, surface license plan, and reword the ready line — diff is mechanical with consistent test updates.

Extended reasoning...

Overview

PR replaces verbose per-phase status output during lstk start with an in-place spinner, adds an inline "Valid license ()" message during license validation, and rewords the final ready line from "LocalStack ready" to "LocalStack is running". It also adds a ForceStop helper on the spinner component for terminal/error paths and hides the pull progress when the spinner stops. Touches internal/container/start.go, internal/output/plain_format.go, internal/ui/app.go, internal/ui/components/spinner.go, plus two unit test files and two integration tests that match the new strings.

Security risks

None. This is purely a presentation/output change — no auth, crypto, network, or permission surfaces are modified. The license validation logic itself is unchanged; only the surrounding UX is adjusted.

Level of scrutiny

Low. The diff is small, mechanical, and self-contained, with tests updated to the new strings in lockstep. PlanDisplayName() already exists in internal/api/client.go (with nil-safety) and is also used in internal/container/label.go, so the new call site has precedent. ForceStop is a simple, well-documented helper.

Other factors

The bug hunting system found no issues. The integration tests in awsconfig_test.go and version_resolution_test.go have been updated to match the new output strings, so CI will catch any regression in the renamed phrases. The formatStatusLine switch still handles the now-unused starting/waiting phases, but that is harmless dead-format code rather than a defect.

@carole-lavillonniere carole-lavillonniere merged commit 82e95d5 into main May 21, 2026
13 checks passed
@carole-lavillonniere carole-lavillonniere deleted the des-233-make-start-header-more-compact branch May 21, 2026 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants