Prompt for login before emulator selection on first run#270
Merged
gtsiolis merged 2 commits intoMay 28, 2026
Merged
Conversation
gtsiolis
requested review from
anisaoshafi,
carole-lavillonniere and
silv-io
as code owners
gtsiolis
force-pushed
the
des-238-prompt-for-login-before-emulator-selection-on-first-run
branch
from
6e5df70 to
7544760
Compare
gtsiolis
force-pushed
the
des-238-prompt-for-login-before-emulator-selection-on-first-run
branch
from
7544760 to
9b1150a
Compare
anisaoshafi
reviewed
May 28, 2026
anisaoshafi
reviewed
May 28, 2026
anisaoshafi
reviewed
May 28, 2026
Collaborator
anisaoshafi
left a comment
anisaoshafi
left a comment
There was a problem hiding this comment.
Good catch 🎣 George, this is a better approach!
Only have a concern about the test.
gtsiolis
force-pushed
the
des-238-prompt-for-login-before-emulator-selection-on-first-run
branch
from
9b1150a to
d897dda
Compare
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
gtsiolis
force-pushed
the
des-238-prompt-for-login-before-emulator-selection-on-first-run
branch
from
d897dda to
7000c71
Compare
Member
Author
|
Thanks both, resolved comments in 7000c71. Please, take another look when you're free! 🍬 🍬 |
anisaoshafi
approved these changes
May 28, 2026
Collaborator
|
|
gtsiolis
deleted the
des-238-prompt-for-login-before-emulator-selection-on-first-run
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a fresh install with no stored credentials,
lstkcurrently shows the emulator picker first and only then starts the login flow. That order is backwards:This flips the order so first-run users see the login screen first, then the emulator picker.
Cc @anisaoshafi @carole-lavillonniere because #217