[Bug fix] Resolving issue with "://" index check always processing#213
Merged
whummer merged 1 commit intolocalstack:masterfrom Mar 18, 2023
OnlyImmutable:patch-1
Merged
[Bug fix] Resolving issue with "://" index check always processing#213whummer merged 1 commit intolocalstack:masterfrom OnlyImmutable:patch-1
whummer merged 1 commit intolocalstack:masterfrom
OnlyImmutable:patch-1
Conversation
Resolving a bug where the checks to see if `this.config.host` contains :// always returns true resulting in exceptions for invalid uri. This is happening because indexOf returns -1 not false resulting in the value always technically being true.
whummer
approved these changes
Mar 18, 2023
Member
There was a problem hiding this comment.
Thanks for this fix @OnlyImmutable ! 🙌 We'll release a new version of the plugin shortly.. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolving a bug where the checks to see if
this.config.hostcontains :// always returns true resulting in exceptions for invalid uri.This is happening because indexOf returns -1 not false resulting in the value always technically being true.