Skip to content

Conversation

@steffyP
Copy link
Member

@steffyP steffyP commented Jan 19, 2026

General cleanup:

  • add description to the action.yml files
  • updated the use of LOCALSTACK_AUTH_TOKEN and remove outdated references to api key
    • including README update
    • replace usage of secrets.LOCALSTACK_API_KEY with secrets.LOCALSTACK_AUTH_TOKEN
  • updated the LICENSE copyright year + owner

Followup tasks

  • ephemeral feature:

    • setup improvements (currently facing known issues with timeouts)
    • fixup tests in emphermal.yml (api seems to have issues currently though)
  • check and potentially update other third party actions

@github-actions
Copy link

github-actions bot commented Jan 19, 2026

⚡️ Running CI build with LocalStack ...

@steffyP steffyP mentioned this pull request Jan 26, 2026
@steffyP steffyP force-pushed the cleanup branch 3 times, most recently from e7ed2ab to 8e4b4e6 Compare January 27, 2026 10:14
MIT License

Copyright (c) 2022 Harsh Mishra
Copyright (c) 2022-2026 LocalStack
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: is that the right way to do it? Happy to change it back, but I guess as we have the action in the organization it makes more sense to use "LocalStack"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looks good to me! Imho this is only there for historical reasons, the action was handed over from @HarshCasper early after the initial creation. However, maybe we could just adjust it according to @HarshCasper's directions in a follow up.

@steffyP steffyP changed the title cleanup cleanup: add descriptions, update auth-token usage Jan 27, 2026
@steffyP steffyP marked this pull request as ready for review January 27, 2026 10:35
@steffyP steffyP requested a review from alexrashed January 27, 2026 10:35
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The action is getting cleaner and cleaner with every PR! The changes here are looking good to me!
However, you mentioned in the PR description that this PR should contain some GitHub action digest updates, even though I couldn't see them in the changeset. Has this been superseded, or did I miss it? :)

MIT License

Copyright (c) 2022 Harsh Mishra
Copyright (c) 2022-2026 LocalStack
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looks good to me! Imho this is only there for historical reasons, the action was handed over from @HarshCasper early after the initial creation. However, maybe we could just adjust it according to @HarshCasper's directions in a follow up.

@steffyP
Copy link
Member Author

steffyP commented Jan 27, 2026

However, you mentioned in the PR description that this PR should contain some GitHub action digest updates, even though I couldn't see them in the changeset. Has this been superseded, or did I miss it? :)

I updated the description a couple of times to reflect the actual changes, maybe it was an outdated description version?

It's currently listed under "followup tasks": check and potentially update other third party actions.
So expect another PR soon 😅 I thought it would be cleaner this way.

@steffyP steffyP merged commit 40084a8 into main Jan 27, 2026
5 checks passed
@steffyP steffyP deleted the cleanup branch January 27, 2026 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants