Conversation
thrau
approved these changes
Mar 2, 2026
Member
thrau
left a comment
There was a problem hiding this comment.
LGTM! even though i did really like the iterator pattern 😁
thanks for fixing this so quickly and adding the test!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sending data as generators does not set the Content-Length header in the POST request, which is required by the Tinybird /v0/datasources endpoint. Hence, calling the method
append_ndjsonthrows the following error:Already reported by @Pive01 in this Slack thread.
Extra considerations:
/v0/datasourcesendpoint limit is at 5 times per minute [2]Since we receive few records to iterate over, it makes sense to keep sending data in batches via the
/v0/datasourcesendpoint. Once more data flows, we can consider the usage of the/v0/eventsendpoint + generators.