GEOMESA-1363 - The Native API should allow an AccumuloGeoMesaIndex to…#1023
Merged
Conversation
… be instantiated with an Accumulo Connector GEOMESA-1364 The Native API should allow the user to compute the list of Accumulo tables for a feature type before the tables exist in Accumulo Added unit tests for both of these functions. Signed-off-by: Chris Eichelberger <cne1x@ccri.com>
| val DISPLAY_NAME = "Accumulo (GeoMesa)" | ||
| val DESCRIPTION = "Apache Accumulo\u2122 distributed key/value store" | ||
|
|
||
| val EmptyParams: JMap[String, Serializable] = new java.util.HashMap[String, Serializable]() |
Contributor
There was a problem hiding this comment.
might be good to wrap this in a Collections.immutableMap just to be safe
| security.getAuthorizationsProvider(params, auths) | ||
| } | ||
|
|
||
| def createDataStore(connector: Connector, params: JMap[String, Serializable] = EmptyParams): AccumuloDataStore = { |
Contributor
There was a problem hiding this comment.
since we can pass the connector in through the param map in the other createDataStore method, do we need this at all? Not sure if it's doing something slightly different.
Contributor
Author
There was a problem hiding this comment.
That's an excellent point. I had missed that we had a parameter defined for the connection. Looking at the createDataStore method, though, it doesn't appear as though we have explicit support for re-using a provided Connection, which I will add in lieu of the explicitly retyped routine I created. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… be instantiated with an Accumulo Connector
GEOMESA-1364 The Native API should allow the user to compute the list of Accumulo tables for a feature type before the tables exist in Accumulo
Added unit tests for both of these functions.
Signed-off-by: Chris Eichelberger cne1x@ccri.com