Skip to content

Conversation

@metasim
Copy link
Member

@metasim metasim commented Aug 22, 2019

Depends on #301

metasim and others added 15 commits August 19, 2019 12:34
* fix/295:
  Reenabled test (mostly) covered by 242.
  Fix for columnar functions which accept `Tile` or `ProjectedRasterTile`, but claimed all return values were `Tile`. This was problematic whenever the `Tile` as reified, and the serialization of `ProjectedRasterTile` confused the `Tile` deserializer.
  Updated copyright in template.
  Update LICENSE
* develop:
  Expressions returning primitives can't return `null`, so changing how constant tiles are created to keep catalyst optimizer from pruning them.
  Added tests for rf_convert_cell_type and rf_with_no_data. Fixed a bug with counting data/no_data cells on constant tiles.
  Additional fixes for issue locationtech#242 that cropped back up.
  Bump python development version to match JVM version

# Conflicts:
#	core/src/main/scala/org/locationtech/rasterframes/ref/RasterRef.scala
#	core/src/main/scala/org/locationtech/rasterframes/tiles/ProjectedRasterTile.scala
#	pyrasterframes/src/main/python/tests/RasterFunctionsTests.py
* develop:
  Add ignored test from stale branch
  mm
  m
  a
  Time series doc reorg vector filtering
  time series park geojson filepath variabl
  ci tweak to get error markdown
  Attempt to save markdown artifacts on failed docs build.
  Attempt to save markdown artifacts on failed docs build.
  Tweak partitions
  Add folium to setup / requirements
  DataFrame API only, folium display of temp file
  Add failing unit test for rf_explode_tiles_resample
* develop:
  Fixed table rendering test.
  Misc tweaks to address PR feedback.
  Added ellipsis to truncated table cells in Markdown and HTML renderers.
  Bug was with changes to `rf_with_no_data` acceptance of either `Double` or `Int`, and then incorrectly changing floating point tiles into a float cell type. Fixes locationtech#304.
  Updated ShowableTile to render NoData values differently.
  Moved array function tests to RasterFunctionsSpec.
  Remove last running example from function ref page
  Update rendered notebook results with new ipython display integration

# Conflicts:
#	docs/src/main/paradox/release-notes.md
Signed-off-by: Jason T. Brown <jason@astraea.earth>
@metasim
Copy link
Member Author

metasim commented Aug 22, 2019

@metasim metasim requested a review from vpipkt August 22, 2019 20:20
@vpipkt
Copy link
Member

vpipkt commented Aug 22, 2019

Once all the #301 things are sorted this is great.

Copy link
Member

@vpipkt vpipkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ ✔️

@vpipkt
Copy link
Member

vpipkt commented Aug 22, 2019

@metasim on your local web server do you get bad links when clicking the search result. In the Circle one i get links like

https://1292-174014757-gh.circle-artifacts.com/0/rf-site//nodata-handling.html#nodata-and-local-arithmetic

And so the double slashes ahead of nodata-handling breaks the link.

@metasim metasim changed the title New, modern documentation theme with built-in search. New, modern documentation theme with built-in search Aug 23, 2019
@metasim
Copy link
Member Author

metasim commented Aug 23, 2019

@metasim on your local web server do you get bad links when clicking the search result. In the Circle one i get links like

https://1292-174014757-gh.circle-artifacts.com/0/rf-site//nodata-handling.html#nodata-and-local-arithmetic

If you change the double // to / it should work.

@metasim metasim merged commit dc050ad into locationtech:develop Aug 23, 2019
@metasim metasim deleted the feature/searchable-docs branch August 23, 2019 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants