Merged
Conversation
lockwo
reviewed
Jun 9, 2024
Owner
lockwo
left a comment
lockwo
left a comment
There was a problem hiding this comment.
Thanks so much for this PR! I think it's a really great start.
Contributor
Author
|
Hi @lockwo thank you for the detailed reply :) I've added all the requested changes, except the vmap which I've left to vectorize for the moment, let me know if there is anything else I can do. |
lockwo
approved these changes
Jun 10, 2024
Owner
lockwo
left a comment
lockwo
left a comment
There was a problem hiding this comment.
LGTM, thanks for the quick turnaround
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
Thank you for initiating this project, exactly what I was looking for 😀
In this PR i've intended to add the mvn tri distribution (and i'm planning to add the one hot categorical soon)
I'm not familiar with distrax so i'm not sure if I did everything correctly, in particular in dropping the batch dimension in TriangularLinear bijector.
However I've ran some basic tests where I check whether logprobs return same value than distrax's logprobs and seems to work well, but might need to do more thorough checking.