Remove gz #8
Merged
Remove gz #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forrest-rm
approved these changes
Aug 7, 2025
forrest-rm
left a comment
forrest-rm
left a comment
There was a problem hiding this comment.
Two small comments, but otherwise looks good.
SushiRaj99
approved these changes
Aug 7, 2025
SushiRaj99
left a comment
SushiRaj99
left a comment
There was a problem hiding this comment.
Looks good to me. Since it's an open source repo, maybe we can open a PR to the main branch with just the changes to the URDF and with the new macros.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the dependency on
realsense2_gz_descriptionand enables compatibility with the newly refactored gz_camera_descriptions repo (had to add inertia to the color frame so that the simulated camera works.I also removed
framefrom the name in the joints (they are joints not frames).