query re: polyfilling json.parse

[SignpostMarv]

I'm curious as to why json_decode has a polyfill for json.parse, are there supported environments where json.parse does not exist?

[SignpostMarv]

For context on my query; Node has had json.parse since 2013; https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/JSON/parse#browser_compatibility

[kvz]

Node.js didn’t exist when that was added and browser support wasn’t a given either when we started out. Also I think feature parity with PHP requires allowing flags to change behavior that JSON.parse doesn’t support.

doesn’t the function have some disclaimers around this and when not to use it? It should I think

[SignpostMarv]

it's getting picked up by rolldown when I'm using sprintf 🤷‍♂️

it looks like there's no support for flags in json_decode(), it uses json.parse if present then falls back to polyfill

locutus/src/php/json/json_decode.ts

Line 28 in e39478b

if (typeof json === 'object' && json !== null) {

[kvz]

Thanks for the detailed report. I dug a bit into it and you were right to flag this.

I checked the sprintf path: sprintf itself does not import JSON at runtime. The JSON code was most likely coming along through broader package/barrel imports plus conservative bundler behavior around re-export side effects.

I shipped v3.0.35 with two changes:

• removed the legacy eval fallback from php/json/json_decode
• added "sideEffects": false to the package metadata so bundlers can more
  confidently drop unrelated re-export branches

Release: https://github.com/locutusjs/locutus/releases/tag/v3.0.35

The json_decode() PHP flags/depth/associative behavior is still a separate parity gap. This release only removes the unsafe/dead fallback path and improves tree-shaking metadata.

Could you retry with locutus@3.0.35? For the smallest bundle, the preferred import remains:

import { sprintf } from 'locutus/php/strings/sprintf'

If JSON still shows up from that direct import path, a small Rolldown repro would be very useful.

[SignpostMarv]

That's fixed the warning, thanks 👍

I checked the actual output and it looks like prior to 3.0.35 that using:

import {
	php,
} from 'locutus';

export default (
	value: string,
	...args: string[]
): string => {
	if (args.length < 1) {
		return value;
	}

	const result = php.strings.sprintf(value, ...args);

	if (false === result) {
		throw new Error('Failed to format string!');
	}

	return result;
};

with rolldown v1.0.0-rc.18 pulled in these into the chunk for sprintf:

• node_modules/locutus/esm/php/datetime/strtotime.js
• node_modules/locutus/esm/php/strings/sprintf.js
• node_modules/locutus/esm/python/math/isqrt.js

after updating to locutus 3.0.35, it only has:

• node_modules/locutus/esm/php/strings/sprintf.js