improve clarity on provider options and set_option#1390
Merged
pascalbreuninger merged 1 commit intoloft-sh:mainfrom Dec 10, 2024
Merged
improve clarity on provider options and set_option#1390pascalbreuninger merged 1 commit intoloft-sh:mainfrom
pascalbreuninger merged 1 commit intoloft-sh:mainfrom
Conversation
abdulari
force-pushed
the
abdulari/improve-cli-clarity
branch
from
3a166ec to
c177e0a
Compare
pascalbreuninger
approved these changes
Nov 27, 2024
Member
pascalbreuninger
left a comment
pascalbreuninger
left a comment
There was a problem hiding this comment.
LGTM, thank you for the contribution @abdulari 🙌
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
improve CLI clarity for
provider optionsandprovider set-optionsthat both will accept optionalproviderparameter.