Only report erorrs not EOF since this is expected when the SSH session ends#1492
Merged
pascalbreuninger merged 1 commit intoloft-sh:mainfrom Dec 19, 2024
Merged
Conversation
pascalbreuninger
approved these changes
Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when you end a SSH session that has port forwarding or reverse forwarding an error is printed superfluously. The underlying EOF error is expected since the sessions was closed so it should not be reported. This was confusing an OSS user and when using reverse forward it's printed locally and makes it seem the command failed. This PR fixes it by checking if it is EOF
e.g.