Skip to content

Base 64 encode and decode signing key#1496

Merged
pascalbreuninger merged 1 commit intoloft-sh:mainfrom
bkneis:feature/base64encode
Dec 19, 2024
Merged

Base 64 encode and decode signing key#1496
pascalbreuninger merged 1 commit intoloft-sh:mainfrom
bkneis:feature/base64encode

Conversation

@bkneis
Copy link
Copy Markdown
Contributor

@bkneis bkneis commented Dec 19, 2024

Fixes #1438

Not sure how to test this one. I ran up using the problematic workspace and could SSH and use my git credentials. But since my signing key doesn't cause an issue I can't replicate. But I can confirm the base64 decode / encode works

@bkneis bkneis requested a review from a team December 19, 2024 09:44
Copy link
Copy Markdown
Member

@pascalbreuninger pascalbreuninger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pascalbreuninger pascalbreuninger merged commit 5508a24 into loft-sh:main Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Starting container with --debug prints repeating fatal error

2 participants