Skip to content

chore/open vscode logs#1535

Merged
pascalbreuninger merged 2 commits intoloft-sh:mainfrom
pascalbreuninger:chore/open-vscode-logs
Jan 10, 2025
Merged

chore/open vscode logs#1535
pascalbreuninger merged 2 commits intoloft-sh:mainfrom
pascalbreuninger:chore/open-vscode-logs

Conversation

@pascalbreuninger
Copy link
Copy Markdown
Member

  • chore(cli): only report errors when opening VSCode if at least one method from CLI and custom scheme actually fails
  • chore(cli): add displayName to VSCode flavor for clearer log output

…thod from CLI and custom scheme actually fails
@pascalbreuninger pascalbreuninger requested a review from a team January 10, 2025 13:04
Copy link
Copy Markdown
Contributor

@bkneis bkneis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pascalbreuninger pascalbreuninger merged commit 8e5ace8 into loft-sh:main Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants