fix/create pro workspace trailing slash#1578
Merged
pascalbreuninger merged 2 commits intoloft-sh:mainfrom Jan 20, 2025
Merged
Conversation
Member
pascalbreuninger
commented
Jan 20, 2025
pascalbreuninger
commented
- chore(pro): hide 'try to enable debug logs' line if pro command has been executed by DevPod Desktop.
- fix(cli): remove trailing / from workspace source
executed by DevPod Desktop. These commands are intended for internal usage and shouldn't print anything user facing without explicitly requesting
pascalbreuninger
force-pushed
the
fix/create-pro-workspace-trailing-slash
branch
2 times, most recently
from
eb76157 to
25649d9
Compare
bkneis
approved these changes
Jan 20, 2025
Contributor
bkneis
left a comment
bkneis
left a comment
There was a problem hiding this comment.
LGTM! Nice addition of the unit tests
pascalbreuninger
force-pushed
the
fix/create-pro-workspace-trailing-slash
branch
from
25649d9 to
1cfbca0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.