fix/POD 1270 deleted pro workspace shows up in cli#1579
Merged
pascalbreuninger merged 2 commits intoloft-sh:mainfrom Jan 20, 2025
Merged
Conversation
Member
pascalbreuninger
commented
Jan 20, 2025
pascalbreuninger
commented
- fix(cli): synchronize deleted pro workspace with remote state by comparing local response vs remote instances
- chore(cli): improve list command with multiple pro providers
by comparing local response vs remote instances Cleans up orphaned local workspace files if necessary
bkneis
reviewed
Jan 20, 2025
pascalbreuninger
force-pushed
the
fix/POD-1270-deleted-pro-workspace-shows-up-in-cli
branch
from
c774907 to
09103b6
Compare
bkneis
approved these changes
Jan 20, 2025
Contributor
bkneis
left a comment
bkneis
left a comment
There was a problem hiding this comment.
LGTM, just one nit and a Q
pascalbreuninger
force-pushed
the
fix/POD-1270-deleted-pro-workspace-shows-up-in-cli
branch
2 times, most recently
from
6fc6846 to
2dbe2bb
Compare
Run `listProProvider` in parallel
pascalbreuninger
force-pushed
the
fix/POD-1270-deleted-pro-workspace-shows-up-in-cli
branch
from
2dbe2bb to
a9606b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.