Fix kubernetes not resetting sources#1580
Merged
pascalbreuninger merged 1 commit intoloft-sh:mainfrom Jan 20, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes - #1072
This issue was that the
devpod agent container setupcommand that streams the mounts to the PVC only did so if the mount's target was empty. This indicates an initial set up where we need to copy the local files over. In order to not override changes to the files in the devpod, we only did this when the mount was empty in the workspace (initial setup).But in the event of a reset, we want the sources to be overridden with the local changes, this flow is common for instance to update to .devcontainer.json. Therefore the fix was to check if the reset option was used and if so, stream the mounts, even if not empty, overriding the workspace contents with the local (source).