feat(pro): auto-mount kubeconfig of virtual cluster/space instance into workspace#1609
Merged
pascalbreuninger merged 1 commit intoloft-sh:mainfrom Feb 3, 2025
Conversation
pascalbreuninger
force-pushed
the
feat/POD-1296-auto-mount-kubeconfig
branch
2 times, most recently
from
ff18716 to
37ccfe3
Compare
bkneis
reviewed
Feb 3, 2025
bkneis
reviewed
Feb 3, 2025
bkneis
reviewed
Feb 3, 2025
bkneis
approved these changes
Feb 3, 2025
Contributor
bkneis
left a comment
bkneis
left a comment
There was a problem hiding this comment.
Nice clean code, just a couple of minor remarks
pascalbreuninger
force-pushed
the
feat/POD-1296-auto-mount-kubeconfig
branch
from
37ccfe3 to
ca121af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.