Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Linux release builds were failing at link time with duplicate
google::protobuf::*symbols because:sentencepiece-sys(via CT2 Whisper) vendors protobuf-lite objectsort-sys(viaortin the old Silero VAD impl) links a staticlibonnxruntime.athat also contains protobuf-liteWhat
ort-based Silero VAD with sherpa-onnx's VAD C-API viasherpa-rs-sysortdependency entirely so ONNX Runtime's static archive is no longer linked into the appHow To Test
CI (Linux Matrix)should build the tarball and pass installer smoke + UI E2Ecd app/src-tauri && cargo build --release